Use regex-lite for chrono-tz-build #170
Open
+3
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There has been some performance tuning in the past. Maybe the benchmark example is useful to compare? |
|
Note that this does not change the dependency for the parse-zoneinfo crate -- only for the chrono-tz-build crate, which I think is only used for the |
pitdicker
approved these changes
Apr 16, 2024
There was a problem hiding this comment.
Sorry, it was a comment without looking closely.
The principal difference between the
regexandregex-litecrates is that the latter prioritizes smaller binary sizes and shorter Rust compile times over performance and functionality.
Locally with a CHRONO_TZ_TIMEZONE_FILTER and the filter-by-regex feature it saves 1% of the build time. I don't see much of an advantage t.b.h.
|
Going to wait until after #172. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We don't need a featureful or high-performance parser for the build script.